I FIXED NS!$!$!$!

asmodee

connect 66.146.206.200


kthnx bubye.

Yes, classic NS no longer crashes marines. I figured out a way to fix it.

After it's thoroughly tested I'll release the fix to the community.

SounDWavE1

<!--quoteo(post=1691245:date=Oct 24 2008, 12:29 AM:name=asmodee)--><div class='quotetop'>QUOTE(asmodee @ Oct 24 2008, 12:29 AM) <a href="index.php?act=findpost&pid=1691245"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->connect 66.146.206.200
kthnx bubye.

Yes, classic NS no longer crashes marines. I figured out a way to fix it.

After it's thoroughly tested I'll release the fix to the community.<!--QuoteEnd--></div><!--QuoteEEnd-->
You haxzor asmodee

w0dk4

Fixed it too <img src="style_emoticons/<#EMO_DIR#>/smile-fix.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile-fix.gif" />

193.192.58.150:27015

Commander is not displayed in the scoreboard, but he/she gets a nice icon <img src="style_emoticons/<#EMO_DIR#>/wink-fix.gif" style="vertical-align:middle" emoid=";)" border="0" alt="wink-fix.gif" />

asmodee

<!--quoteo(post=1691254:date=Oct 23 2008, 09:24 PM:name=w0dk4)--><div class='quotetop'>QUOTE(w0dk4 @ Oct 23 2008, 09:24 PM) <a href="index.php?act=findpost&pid=1691254"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->Fixed it too <img src="style_emoticons/<#EMO_DIR#>/smile-fix.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile-fix.gif" />

193.192.58.150:27015

Commander is not displayed in the scoreboard, but he/she gets a nice icon <img src="style_emoticons/<#EMO_DIR#>/wink-fix.gif" style="vertical-align:middle" emoid=";)" border="0" alt="wink-fix.gif" /><!--QuoteEnd--></div><!--QuoteEEnd-->


Sounds like you implemented the same fix I did then. The icon is a nice touch.

bio

So are we sharing? I need my
<img src="style_emoticons/<#EMO_DIR#>/asrifle.gif" style="vertical-align:middle" emoid="::asrifle::" border="0" alt="asrifle.gif" /> shooting <img src="style_emoticons/<#EMO_DIR#>/pudgy.gif" style="vertical-align:middle" emoid="::gorge::" border="0" alt="pudgy.gif" />

asmodee

I added icon to mine too. I used the veteran icon though. <img src="style_emoticons/<#EMO_DIR#>/tounge.gif" style="vertical-align:middle" emoid=":p" border="0" alt="tounge.gif" />

R3N3GAD3

Can you give us an idea of how you fixed it so we can help you work on it?

Thanks,

Infro

Aight, the day is over so, for all who know how to write a plugin here is what they did.

When you get message 84/ScoreInfo, check to see if Arg6 (class) is equal to 13 (commanderclass).
If it is, either change Arg6 to 1 (marineclass) or just block the message enterly
To change the icon, modify Arg7
Cheers to the Asmodee, Kittyburgers, and all the people we forced onto marines after being told not to join the server to see if the plugin worked as we watched them crash.

Edit:
Just in case,

<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->#include <amxmodx>
#include <amxmisc>

public plugin_init()
{
  register_message(get_user_msgid("ScoreInfo"),"hook_scoreinfo");
}

public hook_scoreinfo()
{
  if(get_msg_arg_int(6)==13)
  {
    set_msg_arg_int(6,byte,1);
    set_msg_arg_int(7,short,32);
  }
}<!--c2--></div><!--ec2-->

should be something like that, tbh

puzl

Good work guys. It doesn't change the fact that one of the engine api calls is running off the end of a supplied parameter, so there are going to be other 'issues' in the client until this is resolved. But at least for now, people can play using your solution.

Seker

<!--quoteo(post=1691276:date=Oct 24 2008, 05:51 AM:name=Infro)--><div class='quotetop'>QUOTE(Infro @ Oct 24 2008, 05:51 AM) <a href="index.php?act=findpost&pid=1691276"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->Aight, the day is over so, for all who know how to write a plugin here is what they did.

When you get message 84/ScoreInfo, check to see if Arg6 (class) is equal to 13 (commanderclass).
If it is, either change Arg6 to 1 (marineclass) or just block the message enterly
To change the icon, modify Arg7
Cheers to the Asmodee, Kittyburgers, and all the people we forced onto marines after being told not to join the server to see if the plugin worked as we watched them crash.

Edit:
Just in case,

<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->#include <amxmodx>
#include <amxmisc>

public plugin_init()
{
  register_message(get_user_msgid("ScoreInfo"),"hook_scoreinfo");
}

public hook_scoreinfo()
{
  if(get_msg_arg_int(6)==13)
  {
    set_msg_arg_int(6,byte,1);
    set_msg_arg_int(7,short,32);
  }
}<!--c2--></div><!--ec2-->

should be something like that, tbh<!--QuoteEnd--></div><!--QuoteEEnd-->


Can't be compiled :/

mothman

<!--quoteo(post=1691245:date=Oct 24 2008, 01:29 AM:name=asmodee)--><div class='quotetop'>QUOTE(asmodee @ Oct 24 2008, 01:29 AM) <a href="index.php?act=findpost&pid=1691245"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->connect 66.146.206.200
kthnx bubye.

Yes, classic NS no longer crashes marines. I figured out a way to fix it.

After it's thoroughly tested I'll release the fix to the community.<!--QuoteEnd--></div><!--QuoteEEnd-->

Good job! <img src="style_emoticons/<#EMO_DIR#>/smile-fix.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile-fix.gif" />
Can you share this fix?

asmodee

I said I'd release the code today, so here is the code I'm actually using.

<a href="http://evolvens.com/nscrashfix.sma" target="_blank">http://evolvens.com/nscrashfix.sma</a>

And if you don't want to compile it you can download a ready to go version here:

<a href="http://evolvens.com/nscrashfix.amxx" target="_blank">http://evolvens.com/nscrashfix.amxx</a>


Infro and kittyburger helped me test all of the crash scenarios we could think of over several hours yesterday.

EDIT: I see Infro has posted some code already.

asmodee

<!--quoteo(post=1691281:date=Oct 24 2008, 04:12 AM:name=puzl)--><div class='quotetop'>QUOTE(puzl @ Oct 24 2008, 04:12 AM) <a href="index.php?act=findpost&pid=1691281"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->Good work guys. It doesn't change the fact that one of the engine api calls is running off the end of a supplied parameter, so there are going to be other 'issues' in the client until this is resolved. But at least for now, people can play using your solution.<!--QuoteEnd--></div><!--QuoteEEnd-->

We were playing for hours yesterday on my server and the only issue we're aware of is that your screen will always say "No Commander" and there will be no one listed as commander on the scoreboard, thus the idea for the icon. I was going to just write some hud text code that showed up telling you, but the icon idea was much simpler and better imo, so I implemented that into my code too.

EDIT: Also the fact that disabling the screen overlay in game (Infro figured that out when we were testing) prevents you from crashing is quite interesting.

mothman

<!--quoteo(post=1691307:date=Oct 24 2008, 02:05 PM:name=asmodee)--><div class='quotetop'>QUOTE(asmodee @ Oct 24 2008, 02:05 PM) <a href="index.php?act=findpost&pid=1691307"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->I said I'd release the code today, so here is the code I'm actually using.

<a href="http://evolvens.com/nscrashfix.sma" target="_blank">http://evolvens.com/nscrashfix.sma</a>

And if you don't want to compile it you can download a ready to go version here:

<a href="http://evolvens.com/nscrashfix.amxx" target="_blank">http://evolvens.com/nscrashfix.amxx</a>
Infro and kittyburger helped me test all of the crash scenarios we could think of over several hours yesterday.

EDIT: I see Infro has posted some code already.<!--QuoteEnd--></div><!--QuoteEEnd-->


Thanks Asmodee!

This amxx fix crash but make few bugs:
<ul><li>Marines don't see who is the commander, marines show: no commander</li><li>ALL player have this icon and don't work we custom icon system - maybe we need rewrite icon system for new version of HL engine</li><li>We don't see who is died - no died colors at all team</li></ul>
How can we fix these bugs?

asmodee

<!--quoteo(post=1691317:date=Oct 24 2008, 10:08 AM:name=mothman)--><div class='quotetop'>QUOTE(mothman @ Oct 24 2008, 10:08 AM) <a href="index.php?act=findpost&pid=1691317"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->Thanks Asmodee!

This amxx fix crash but make few bugs:<ul><li>Marines don't see who is the commander, marines show: no commander</li><li>ALL player have this icon and don't work we custom icon system - maybe we need rewrite icon system for new version of HL engine</li><li>We don't see who is died - no died colors at all team</li></ul>How can we fix these bugs?<!--QuoteEnd--></div><!--QuoteEEnd-->


I noticed the problem with some custom icon systems. I've updated the plugin to fix this. Make sure you have v0.9.1.

I may make an update that will include HUD text to say who the comm is rather than have the icon, but I can't use the in game method of displaying the comm because that's what triggers the crash.

Oddly, my version from last night actually had code in it that would have accounted for these custom icon systems, but I removed it before posting this morning because I found (on my server) it wasn't necessary. Turns out it was.

[G4B2S]Obi

Great work Asmodee! <img src="style_emoticons/<#EMO_DIR#>/pudgy.gif" style="vertical-align:middle" emoid="::gorge::" border="0" alt="pudgy.gif" />

This has been applied to our server at 66.228.126.57:27015 and is working quite well.

TinCan

Thank you asmodee.

asmodee

Any further updates will be posted to:

<a href="http://www.nsmod.org/forums/index.php?showtopic=15287" target="_blank">http://www.nsmod.org/forums/index.php?showtopic=15287</a>

TheNinthPlayer

If you look up Resourceful in the dictionary you will find Asmodee!

mothman

<!--quoteo(post=1691319:date=Oct 24 2008, 04:27 PM:name=asmodee)--><div class='quotetop'>QUOTE(asmodee @ Oct 24 2008, 04:27 PM) <a href="index.php?act=findpost&pid=1691319"><{POST_SNAPBACK}></a></div><div class='quotemain'><!--quotec-->I noticed the problem with some custom icon systems. I've updated the plugin to fix this. Make sure you have v0.9.1.

I may make an update that will include HUD text to say who the comm is rather than have the icon, but I can't use the in game method of displaying the comm because that's what triggers the crash.

Oddly, my version from last night actually had code in it that would have accounted for these custom icon systems, but I removed it before posting this morning because I found (on my server) it wasn't necessary. Turns out it was.<!--QuoteEnd--></div><!--QuoteEEnd-->

Can you just remove all not needed icon changes and remove any message about commander?
We have custom icon systems and this patch override it.
Asmodee, thanks your fast support! <img src="style_emoticons/<#EMO_DIR#>/smile-fix.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile-fix.gif" />

asmodee

Which custom icon system are you using? The newest version, v0.9.1 works with several servers that use custom icons now. The original version, 0.9 had issue with some of them.

If I remove the code giving the comm a special icon, then you will not know who the commander is, or if there is a commander.

However, if you insist on not having an icon for the commander or if the v0.9.1 doesn't work for you and you don't want to help test a fix for your server, I've uploaded a special version just for you:

<a href="http://evolvens.com/nscrashfix-alternate.amxx" target="_blank">http://evolvens.com/nscrashfix-alternate.amxx</a>


I would of course prefer that you work with me to develop a fix for your custom icon system, since all the other servers that are running this fix are having success.

Please let me know of any success or failure.

lilflip

CHEERSSS thx, time to kill some alionnsss <img src="style_emoticons/<#EMO_DIR#>/asrifle.gif" style="vertical-align:middle" emoid="::asrifle::" border="0" alt="asrifle.gif" />

Golgo

I forgot to crongrat and thank you on g4b2s forums, so i'll do it here.

Good job and thanks!

GolgoThirteen

Oops wrong account, but yeah ;P

Toughsox

I just got all warm and funny inside. THANKS ASMODEE, KITTY & INFRO !!! <img src="style_emoticons/<#EMO_DIR#>/tiny.gif" style="vertical-align:middle" emoid="::onos::" border="0" alt="tiny.gif" />

Grizzlywolf

hey, I have a basic idea that might help sort of mimic the commander name showing up,
is it possible, rather then using icon (for people with those issues) you could have it display the com's name where it would normally say "using amxx ver xx.xx" on the bottom? (motd i believe)

this would be out of the way, easy to find/see, and it isn't a very openly used channel anyways.
but, im not entirely sure if this can be used for just one team, rather then entire server...

if nothing else, a small amx popup type message (like xmenu etc) could be used for when com goes in/out, and could refresh every 10 or so seconds if there is no com.

com enters, "xxxx has taken commander"
com leaves, "xxxx has left commander"
every 10 or so seconds there is no com "no commander!"

/com display current commander (for late join, random checks)

finally, could hive/ccstats be modified for this purpose?

and thanks again, major props working around someone else's epic f' up... ( valve...)

asmodee

I'm trying to find a way to trick the game into putting the comm's name where it should be. I've not been sucessful thus far.

I would prefer not using hud messages because more messages = higher chance of svc_bad, and that's already an issue on some servers.

So I'm still working on a better fix, but don't expect much. I can try a hud msg fix if someone who has a well populated server is willing to test it.

Raza.

Seems like it's been fixed now, Steam update said something about UI crash and HL1 mod.

puzl

We just got word from Valve that they have found and fixed the problem and the fix will go out soon. Some of the info you posted was very helpful in pinpointing the issue, so once again thanks to everyone for putting in the huge effort. I hope you guys close to a perfect solution aren't too disappointed <img src="style_emoticons/<#EMO_DIR#>/wink-fix.gif" style="vertical-align:middle" emoid=";)" border="0" alt="wink-fix.gif" />

edit: wow that was fast!!!! Valve truly roxor!

Bacsu

i can confirm this patch. server runs without the fix of asmodee now.
This HL patch caused to much problems in my opinion. Would be nice if there will be a kind of mailing system to server operaters if some heavy changes like this happen at the HL/NS or NS2 engine.

last words... good work asmodee.

asmodee

I'm no longer the savior of NS. <img src="style_emoticons/<#EMO_DIR#>/sad-fix.gif" style="vertical-align:middle" emoid=":(" border="0" alt="sad-fix.gif" />

I've confirmed that my plugin is no longer needed.